SafeWalk Compatibility #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avanatiker
approved these changes
Feb 1, 2023
Avanatiker
force-pushed
the
safewalkCompat
branch
from
1b7e9c5 to
f99fc16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull
SafeWalk compatibility with Future (and any other client) that have the same invoke mixins.
Describe how this pull is helpful
Safewalk does not work with other clients without this compatibility.
I've also set the default value to false for the safe fall setting. This is more in-line with what users will expect. I don't know of any other client that has this enabled by default (or has this setting at all).
Additional context
Future is very popular. Compatibility is good.