fix unfocused clickgui issue #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull
to reproduce issue without this commit:
Describe how this pull is helpful
Issue caused by mouse getting stuck in the DRAG state even when no button was being clicked.
handleMouseInputinGuiScreennever resets this variable until it gets a new mouse click, causing gui's to get a stale mouse button value until the next clickAdditional context
trolled by MC's GuiScreen
didn't find any other way to reset this private variable without an accessor unfortunately.
another option would be to mixin and reset this var in
GuiScreen.onGuiClosedbut not sure if there's other gui's that depend on this existing behavior.