removed fading animation from tracers #339
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should improve or make it an option instead |
|
make it an option instead :D |
|
Implemented request in #388 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull
This PR removes the fading animation of tracers.
Describe how this pull is helpful
For some reason the Tracers module is written in a way that tracers are not shown or hidden immediately but they fade in and out over the course of maybe 500ms.
In my opinion this defeats the purpose of tracers, since they are meant to display information in a quick and flashy way and they should not try to be subtle and smooth.
It also gives you a significant tactical disadvantage because it will make you notice other players or entities 500ms later than they will notice you. If an entity just quickly pops in and out of your render-range you won't even know it was there, whereas you would have been able to see it with every other utility client.
Furthermore, the fading is not consistent within Lambda, as it only occurs for entities highlighted by the Tracers module. Every other tracer drawn by Lambda (for example in the search module) does not fade, which makes this feature even more confusing.
Please tell me if you think this PR is unjustified.