Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding MapDownloader #312

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Adding MapDownloader #312

merged 1 commit into from
Jun 30, 2022

Conversation

P529
Copy link
Contributor

@P529 P529 commented May 20, 2022

This is a module that saves maps that are displayed in item frames to a png file.

@5HT2
Copy link
Contributor

5HT2 commented May 20, 2022

Shouldn't this be a plugin? This should probably also re-use the utilities that MapPreview uses.

@czho
Copy link
Member

czho commented May 20, 2022

This should be a plugin.

@P529
Copy link
Contributor Author

P529 commented May 20, 2022

Shouldn't this be a plugin? This should probably also re-use the utilities that MapPreview uses.

I was talking to Constructor about it being a plugin or an addition to Lambda itself and we decided it is probably better as a module in the main client. And the thing about MapPreview is that it doesnt share any code and MapPreview is only showing maps in your inventory.

MapDownloader saves every map in your render distance to file so quite different. Or are you saying it should be an option in MapPreview to save the Map you preview to file? That sounds like a different module.

@Avanatiker
Copy link
Member

We need to solve the plugin github api requests limit to add more plugins to the list without having people beeing api limited. thats why i thought it could be in the client for now until we found a solution

@5HT2
Copy link
Contributor

5HT2 commented May 20, 2022

We need to solve the plugin github api requests limit

I'll happily discuss working around this with you on Discord, ping me.

@Avanatiker
Copy link
Member

What if we combine it with MapPreview as one module the code isnt that long and kinda fits.

@Avanatiker Avanatiker changed the title Adding map downloader Adding MapDownloader May 23, 2022
@Avanatiker Avanatiker added the enhancement New feature or request label May 23, 2022
@Avanatiker Avanatiker merged commit e9baf54 into lambda-client:master Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants