Highlighter #31
Merged
Highlighter #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahmatiy
requested changes
May 10, 2023
src/publisher/highlighter.ts
Outdated
| } | ||
|
|
||
| stopInspect() { | ||
| window.removeEventListener('click', this.onClick, true); |
There was a problem hiding this comment.
This will not remove a listener since onClick was added as this.onClick.bind(this). The same for onPointerDown & onPointerUp
src/publisher/highlighter.ts
Outdated
| } | ||
|
|
||
| private selectFiberForNode(node, selected = false) { | ||
| const rendererInterface = this.hook.rendererInterfaces.get(1); |
There was a problem hiding this comment.
We need to iterate through rendererInterfaces and try every interface (supported=true) for a fiber id. Since multiple renderers are not supported, your can add a break after first check, but add a comment for future
src/publisher/highlighter.ts
Outdated
| } | ||
|
|
||
| if (fiberID) { | ||
| this.publisher.ns(HIGHLIGHTER_NS).publish({ fiberID, selected }); |
There was a problem hiding this comment.
I suggest to keep this functionality abstract to communication layer. It's better to pass a callback to highlighter to specify what to do on a fiber selection.
lahmatiy
approved these changes
May 23, 2023
|
@exdis Great job! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlighter initial implementation