Do not set clientSecret for CODE-PKCE (RicoSuter#4184)

lahma · Jan 20, 2024 · 2bd6202 · 2bd6202
1 parent 30709d0
commit 2bd6202
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 6 deletions.
diff --git a/src/NSwag.AspNet.Owin/SwaggerUi3/index.html b/src/NSwag.AspNet.Owin/SwaggerUi3/index.html
@@ -85,16 +85,21 @@
   });
 
   if ("{ClientId}") {
-    ui.initOAuth({
+    const oAuthConfig = {
       clientId: "{ClientId}",
-      clientSecret: "{ClientSecret}",
       realm: "{Realm}",
       appName: "{AppName}",
       scopeSeparator: "{ScopeSeparator}",
       scopes: {Scopes},
       additionalQueryStringParams: {AdditionalQueryStringParameters},
       usePkceWithAuthorizationCodeGrant: {UsePkceWithAuthorizationCodeGrant}
-    });
+    };
+
+    if (!{UsePkceWithAuthorizationCodeGrant}) {
+      oAuthConfig.clientSecret = "{ClientSecret}";
+    }
+
+    ui.initOAuth(oAuthConfig);
   }
 
   window.ui = ui;

diff --git a/src/NSwag.AspNetCore/SwaggerUi3/index.html b/src/NSwag.AspNetCore/SwaggerUi3/index.html
@@ -85,16 +85,21 @@
   });
 
   if ("{ClientId}") {
-    ui.initOAuth({
+    const oAuthConfig = {
       clientId: "{ClientId}",
-      clientSecret: "{ClientSecret}",
       realm: "{Realm}",
       appName: "{AppName}",
       scopeSeparator: "{ScopeSeparator}",
       scopes: {Scopes},
       additionalQueryStringParams: {AdditionalQueryStringParameters},
       usePkceWithAuthorizationCodeGrant: {UsePkceWithAuthorizationCodeGrant}
-    });
+    };
+
+    if (!{UsePkceWithAuthorizationCodeGrant}) {
+      oAuthConfig.clientSecret = "{ClientSecret}";
+    }
+
+    ui.initOAuth(oAuthConfig);
   }
 
   window.ui = ui;