Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetBox 2.9 release #115

Merged
merged 9 commits into from
Nov 5, 2020
Merged

NetBox 2.9 release #115

merged 9 commits into from
Nov 5, 2020

Conversation

lae
Copy link
Owner

@lae lae commented Oct 31, 2020

This introduces feature support for NetBox 2.9. If you can test this branch out by upgrading an existing installation (or copy of one), please do so and report back. Confirmations of successful upgrades will result in a quicker merge (as I'm having some test suite issues I need to resolve currently).

To deploy NetBox 2.9, use ansible-galaxy to install this branch:

ansible-galaxy install https://github.com/lae/ansible-role-netbox/archive/feature/netbox-2.9.tar.gz,v1.1.0-pre,lae.netbox --force

Changes

Not very many significant ones as far as I can tell. If I'm missing anything, please leave a comment.

Closes #112

@ironiq
Copy link

ironiq commented Nov 2, 2020

Just one note: Netbox 2.9+ requires Redis v4.x or later. The default settings in the role davidwittman.redis wants to install 2.8, this is not overridden here. Redhat 7 contains 3.2, Ubuntu 16.04 contains 3.0, so i think that should be mentioned in the README.

@lae lae force-pushed the feature/netbox-2.9 branch from 5d55574 to bcd65e6 Compare November 2, 2020 14:00
@tyler-8
Copy link
Collaborator

tyler-8 commented Nov 4, 2020

Just used this to install in a test instance, worked great!

@lae
Copy link
Owner Author

lae commented Nov 5, 2020

@tyler-8 Can you do me a favour and review the PR changes and approve it?

@lae lae force-pushed the feature/netbox-2.9 branch from bcd65e6 to 81fe89a Compare November 5, 2020 01:47
@lae
Copy link
Owner Author

lae commented Nov 5, 2020

https://travis-ci.org/github/lae/ansible-role-netbox/builds/741530433

(still trying to figure out why travis integration is broken)

Copy link
Collaborator

@tyler-8 tyler-8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the handling of the renamed configuration param. Looks good!

@lae lae merged commit bbc5999 into master Nov 5, 2020
@lae lae deleted the feature/netbox-2.9 branch October 31, 2021 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for NetBox 2.9.X
3 participants