-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NetBox 2.9 release #115
NetBox 2.9 release #115
Conversation
Replace DEFAULT_TIMEOUT by RQ_DEFAULT_TIMEOUT
Just one note: Netbox 2.9+ requires Redis v4.x or later. The default settings in the role davidwittman.redis wants to install 2.8, this is not overridden here. Redhat 7 contains 3.2, Ubuntu 16.04 contains 3.0, so i think that should be mentioned in the README. |
5d55574
to
bcd65e6
Compare
Just used this to install in a test instance, worked great! |
@tyler-8 Can you do me a favour and review the PR changes and approve it? |
bcd65e6
to
81fe89a
Compare
https://travis-ci.org/github/lae/ansible-role-netbox/builds/741530433 (still trying to figure out why travis integration is broken) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the handling of the renamed configuration param. Looks good!
This introduces feature support for NetBox 2.9. If you can test this branch out by upgrading an existing installation (or copy of one), please do so and report back. Confirmations of successful upgrades will result in a quicker merge (as I'm having some test suite issues I need to resolve currently).
To deploy NetBox 2.9, use
ansible-galaxy
to install this branch:Changes
Not very many significant ones as far as I can tell. If I'm missing anything, please leave a comment.
RQ_DEFAULT_TIMEOUT
under redis config (2.9.4 changelog)Closes #112