feature: Support port overrides in connect() #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow for .connect({'*': {host: 'hostname', port: 12345}}) overrides to
change the destination port of a request.
bennbollay
changed the title
niftylettuce
requested changes
Jun 28, 2020
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "superagent", | |||
| "description": "elegant & feature rich browser / node HTTP with a fluent API", | |||
| "version": "5.2.2", | |||
| "version": "5.2.3", | |||
There was a problem hiding this comment.
Please do not version bump package.json. If you remove this commit I will merge it.
There was a problem hiding this comment.
Thanks @niftylettuce !
|
Ill do this myself nvm |
|
v5.3.0 published to npm and GitHub releases page with changelog |
niftylettuce
added a commit
that referenced
this pull request
Jun 28, 2020
This was referenced Jul 16, 2024
This was referenced Aug 2, 2024
This was referenced Sep 6, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for .connect({'*': {host: 'hostname', port: 12345}}) overrides to
change the destination port of a request.