-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactored to support node/browser targets using babel #1423
Changes from all commits
e73da09
947293d
4f7a99a
0cc3aef
5cf9453
bf8b9a2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
{ | ||
"presets": [ | ||
["@babel/env", { | ||
"targets": { | ||
"node": "8.8.1", | ||
"browsers": [ "> 1%", "last 2 versions", "ie >= 9" ] | ||
} | ||
}] | ||
] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# Browsers that we support | ||
|
||
> 1% | ||
last 2 versions | ||
ie >= 9 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
root = true | ||
|
||
[*] | ||
indent_style = space | ||
indent_size = 2 | ||
end_of_line = lf | ||
charset = utf-8 | ||
trim_trailing_whitespace = true | ||
insert_final_newline = true |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"env": { "browser": true" }, | ||
"plugins": ["compat"], | ||
"rules": { "compat/compat": "error" }, | ||
"settings": { "polyfills": [ "promises" ] } | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
* text=auto |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,17 @@ | ||
build | ||
lib-cov | ||
coverage.html | ||
.DS_Store | ||
node_modules | ||
*.sock | ||
test.js | ||
components | ||
test/node/fixtures/tmp.json | ||
.idea | ||
superagent.js | ||
package-lock.json | ||
package-lock.json | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: while not a change you made, |
||
.DS_Store | ||
*.log | ||
.idea | ||
node_modules | ||
coverage | ||
.nyc_output | ||
lib | ||
dist |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,3 +5,5 @@ examples | |
lib-cov | ||
coverage.html | ||
bower.json | ||
.nyc_output | ||
coverage | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: I don't think this file isn't being used because we already specify the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I had a scenario which happened multiple times (and I reported to NPM) where despite |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
CONTRIBUTING.md | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this repo use Remark? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is now using it (via my PR), I have to update the contributors block still, it's pretty cool - gets read from |
||
HISTORY.md | ||
docs |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
When submitting a PR, your chance of acceptance increases if you do the following: | ||
|
||
* Code style is consistent with existing in the file. | ||
* Tests are passing (client and server). | ||
* You add a test for the failing issue you are fixing. | ||
* Code changes are focused on the area of discussion. | ||
* Do not rebuild the distribution files or increment version numbers. | ||
|
||
|
||
## Contributors | ||
|
||
| Name | Website | | ||
| ------------------- | -------------------------- | | ||
| **TJ Holowaychuk** | <http://tjholowaychuk.com> | | ||
| **Kornel Lesiński** | | | ||
| **Peter Lyons** | | | ||
| **Hunter Loftis** | | | ||
| **Nick Baugh** | | |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: is there a way to use the
.browserlistrc
file here so we don't have duplicated config?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is not