Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: visible state #115

Merged
merged 2 commits into from
Jan 22, 2022
Merged

fix: visible state #115

merged 2 commits into from
Jan 22, 2022

Conversation

irohitb
Copy link
Collaborator

@irohitb irohitb commented Jan 21, 2022

No description provided.

@irohitb irohitb closed this Jan 21, 2022
@irohitb irohitb reopened this Jan 21, 2022
@niftylettuce
Copy link
Collaborator

Is this the final fix for v3.0.0 issues?

@irohitb
Copy link
Collaborator Author

irohitb commented Jan 22, 2022

@niftylettuce Yeah.

@niftylettuce niftylettuce merged commit ff3ca51 into ladjs:master Jan 22, 2022
@niftylettuce
Copy link
Collaborator

Got a bunch of TypeScript errors:

$ npm run test && tsc -p .
npm WARN lifecycle The node binary used for scripts is /var/folders/rl/gz_3j8fx4s98k2kb0hknfygm0000gn/T/yarn--1642893184739-0.6755602614594489/node but npm is using /Users/someuser/n/bin/node itself. Use the `--scripts-prepend-node-path` option to include the path for the node binary npm was executed with.

> react-native-loading-spinner-overlay@3.0.0 test /Users/someuser/Projects/react-native-loading-spinner-overlay
> npm run lint

npm WARN lifecycle The node binary used for scripts is /var/folders/rl/gz_3j8fx4s98k2kb0hknfygm0000gn/T/yarn--1642893184739-0.6755602614594489/node but npm is using /Users/someuser/n/bin/node itself. Use the `--scripts-prepend-node-path` option to include the path for the node binary npm was executed with.

> react-native-loading-spinner-overlay@3.0.0 lint /Users/someuser/Projects/react-native-loading-spinner-overlay
> xo && remark . -qfo

node_modules/@types/node/globals.d.ts:47:11 - error TS2300: Duplicate identifier 'AbortController'.

47 interface AbortController {
             ~~~~~~~~~~~~~~~

  node_modules/@types/react-native/globals.d.ts:390:15
    390 declare class AbortController {
                      ~~~~~~~~~~~~~~~
    'AbortController' was also declared here.

node_modules/@types/node/globals.d.ts:60:11 - error TS2300: Duplicate identifier 'AbortSignal'.

60 interface AbortSignal {
             ~~~~~~~~~~~

  node_modules/@types/react-native/globals.d.ts:377:15
    377 declare class AbortSignal {
                      ~~~~~~~~~~~
    'AbortSignal' was also declared here.

node_modules/@types/node/globals.d.ts:67:13 - error TS2300: Duplicate identifier 'AbortController'.

67 declare var AbortController: {
               ~~~~~~~~~~~~~~~

  node_modules/@types/react-native/globals.d.ts:390:15
    390 declare class AbortController {
                      ~~~~~~~~~~~~~~~
    'AbortController' was also declared here.

node_modules/@types/node/globals.d.ts:72:13 - error TS2300: Duplicate identifier 'AbortSignal'.

72 declare var AbortSignal: {
               ~~~~~~~~~~~

  node_modules/@types/react-native/globals.d.ts:377:15
    377 declare class AbortSignal {
                      ~~~~~~~~~~~
    'AbortSignal' was also declared here.

node_modules/@types/react-native/globals.d.ts:377:15 - error TS2300: Duplicate identifier 'AbortSignal'.

377 declare class AbortSignal {
                  ~~~~~~~~~~~

  node_modules/@types/node/globals.d.ts:60:11
    60 interface AbortSignal {
                 ~~~~~~~~~~~
    'AbortSignal' was also declared here.
  node_modules/@types/node/globals.d.ts:72:13
    72 declare var AbortSignal: {
                   ~~~~~~~~~~~
    and here.

node_modules/@types/react-native/globals.d.ts:390:15 - error TS2300: Duplicate identifier 'AbortController'.

390 declare class AbortController {
                  ~~~~~~~~~~~~~~~

  node_modules/@types/node/globals.d.ts:47:11
    47 interface AbortController {
                 ~~~~~~~~~~~~~~~
    'AbortController' was also declared here.
  node_modules/@types/node/globals.d.ts:67:13
    67 declare var AbortController: {
                   ~~~~~~~~~~~~~~~
    and here.

node_modules/@types/vfile/index.d.ts:11:31 - error TS7016: Could not find a declaration file for module 'vfile-message'. '/Users/someuser/Projects/react-native-loading-spinner-overlay/node_modules/vfile-message/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/vfile-message` if it exists or add a new declaration (.d.ts) file containing `declare module 'vfile-message';`

11 import * as vfileMessage from 'vfile-message';
                                 ~~~~~~~~~~~~~~~


Found 7 errors.

error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants