Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove bound prefix from functions when creating keys #30

Merged
merged 1 commit into from
May 26, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/plugins/cache/query-cache.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,11 @@ const getFromCache = (qc, e, k) => {
};
};

const stripBound = (fnName) => fnName.replace(/^bound /, '');

// QueryCache -> Entity -> ApiFunction -> [a] -> [b] -> [b]
export const put = curry((qc, e, aFn, args, xs) => {
const k = createKey(e, [aFn.name, ...filter(identity, args)]);
const k = createKey(e, [stripBound(aFn.name), ...filter(identity, args)]);
if (Array.isArray(xs)) {
qc.cache[k] = toCacheValue(map(prop('__ladda__id'), xs));
} else {
Expand All @@ -52,13 +54,13 @@ export const getValue = (v) => {

// QueryCache -> Entity -> ApiFunction -> [a] -> Bool
export const contains = (qc, e, aFn, args) => {
const k = createKey(e, [aFn.name, ...filter(identity, args)]);
const k = createKey(e, [stripBound(aFn.name), ...filter(identity, args)]);
return inCache(qc, k);
};

// QueryCache -> Entity -> ApiFunction -> [a] -> Bool
export const get = (qc, e, aFn, args) => {
const k = createKey(e, [aFn.name, ...filter(identity, args)]);
const k = createKey(e, [stripBound(aFn.name), ...filter(identity, args)]);
if (!inCache(qc, k)) {
throw new Error(
`Tried to access ${e.name} with key ${k} which doesn't exist.
Expand Down