Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only pull enabled subscriptions #35

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

andrewelizondo
Copy link
Contributor

@andrewelizondo andrewelizondo commented Apr 2, 2022

Description:
This change only selects subscriptions that are able to be modified since they're in an enabled state, trying to modify a disabled/deleted subscription results in a 409 😞

This functionality is also being changed in -> lacework/terraform-azure-activity-log#59

Copy link
Contributor

@marcosgm marcosgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@marcosgm marcosgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dmurray-lacework
Copy link
Collaborator

make it so!

@dmurray-lacework
Copy link
Collaborator

@dmurray-lacework dmurray-lacework changed the title only pull enabled subscriptions fix: only pull enabled subscriptions Apr 4, 2022
@dmurray-lacework dmurray-lacework merged commit 2a6cde1 into lacework:main Apr 4, 2022
@lacework-releng lacework-releng mentioned this pull request Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants