Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow optional storage account network rules to configuation #93

Merged
merged 12 commits into from
Nov 23, 2023

Conversation

dmurray-lacework
Copy link
Collaborator

@dmurray-lacework dmurray-lacework commented Nov 13, 2023

Summary

Set SA network rules default action to Deny

Add new variables to configure azurerm_storage_account_network_rules

  • use_storage_account_network_rules - Defaults to false. If true the following are configuable options
    • storage_account_network_rule_bypass
    • storage_account_network_rule_ip_rules
    • storage_account_network_rule_subnet_ids
    • storage_account_network_rule_action
    • storage_account_network_rule_lacework_ip_rules - Lacework defined allowed ip addresses

How did you test this change?

  • TF apply. Confirm Lacework integration is successful
  • TF update and destroy

Issue

https://lacework.atlassian.net/browse/LINK-2278

Signed-off-by: Darren Murray <darren.murray@lacework.net>
Signed-off-by: Darren Murray <darren.murray@lacework.net>
Signed-off-by: Darren Murray <darren.murray@lacework.net>
Signed-off-by: Darren Murray <darren.murray@lacework.net>
Signed-off-by: Darren Murray <darren.murray@lacework.net>
Signed-off-by: Darren Murray <darren.murray@lacework.net>
Signed-off-by: Darren Murray <darren.murray@lacework.net>
Signed-off-by: Darren Murray <darren.murray@lacework.net>
Signed-off-by: Darren Murray <darren.murray@lacework.net>
Signed-off-by: Darren Murray <darren.murray@lacework.net>
Signed-off-by: Darren Murray <darren.murray@lacework.net>
Signed-off-by: Darren Murray <darren.murray@lacework.net>
@dmurray-lacework dmurray-lacework merged commit f424502 into main Nov 23, 2023
@dmurray-lacework dmurray-lacework deleted the LINK-2278 branch November 23, 2023 14:59
@dmurray-lacework dmurray-lacework changed the title fix: default storage account network rules to 'Deny' fix: allow optional storage account network rules to configuation Nov 23, 2023
@lacework-releng lacework-releng mentioned this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants