feat(RAIN-91423): Add permissions for three sns APIs #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjzhangjjzhang
changed the title
ramgudivada-lacework
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket is here
https://lacework.atlassian.net/browse/RAIN-91423
Summary
aws SecurityAudit policy doesn't have permission for these three SNS APIs.
In this PR, I am adding permissions for these three APIs.
How did you test this change?
The detail test is here https://docs.google.com/document/d/19HrNdVyQrCXARHzPYvOkq4Y3DZvJRmIC3GxKjDU7Np4/edit
Without the terraform change, we see all Access Denied error.
I changed terraform module for a test user.
We no longer see access denied error for the user
Issue
https://lacework.atlassian.net/browse/RAIN-91423