feat(RAIN-91433): Add permission for get-api-keys in apigateway and apigatewayv2 #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjzhangjjzhang
changed the title
jjzhangjjzhang
commented
Dec 14, 2023
| "apigateway:GetVpcLinks"] | ||
| resources = ["*"] | ||
| actions = ["apigateway:GET"] | ||
| resources = ["arn:aws:apigateway:*::/apikeys", "arn:aws:apigateway:*::/apikeys/*"] |
There was a problem hiding this comment.
tested it with the change. both "::/apikeys" and ":::/apikeys/*" are needed
There was a problem hiding this comment.
resources = ["*"]
Why not keep it consistent?
There was a problem hiding this comment.
Here is the conversation. Tasos mentioned about least priviledge rule. https://lacework.slack.com/archives/C01SW6S3NQY/p1702501578650959
ramgudivada-lacework
approved these changes
Dec 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We do not have permission for get-api-keys in apigateway and apigatewayv2.
In this PR, we are adding permissions for this API.
First of all, apigateway and apigatewayv2 are controlled by the same iam actions.
In securityAudit, it actually has permissions for get APi for apigateway and apigatewayv2, but not for resource get-api-keys
How did you test this change?
Verified that the error is access denied without the change.
With this PR on the terraform change, access denied is gone.
Detail test is here https://docs.google.com/document/d/1eQowgxHJ6JXQdMx3oMI5usrI-TvqXq6iw3sm9AqsJp0/edit
Issue
https://lacework.atlassian.net/browse/RAIN-91433