Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update time provider to ~> 0.7 #80

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

spilliams
Copy link
Contributor

@spilliams spilliams commented Oct 9, 2023

Summary

I have an M1 Mac, and when I try to init my configuration that calls on this module (the latest stable, version 0.13.0), I get the error message

╷
│ Error: Required plugins are not installed
│ 
│ The installed provider plugins are not consistent with the packages
│ selected in the dependency lock file:
│   - registry.terraform.io/hashicorp/time: there is no package for registry.terraform.io/hashicorp/time 0.6.0 cached in .terraform/providers
│ 

This is because the time provider version 0.6.0 does not have a binary for my platform (darwin_arm64). The version 0.7.x does: https://github.com/hashicorp/terraform-provider-time/releases

Also note: I ran terraform fmt in the root directory, and that change is reflected in a chore commit in this branch.

How did you test this change?

I ran terraform init when my configuration was

module "aws_config" {
  source  = "lacework/config/aws"
  version = "0.13.0"
}

and it failed. Then I ran init -upgrade when my configuration

module "aws_config" {
  source = "git@github.com:OpenSesame/terraform-aws-config.git/?ref=feature/DEVO-5179/time-outdated"
}

and it inited fine. A subsequent plan showed no changes.

Issue

Hashicorp's `time` provider 0.6.x does not have a binary for the
darwin_arm64 platform, so developers on the new M1/M2 Macs
will not be able to apply this module. The 0.7.x release includes
a darwin_arm64 binary and makes no other changes.
I would also note that `time` is a very stable provider overall
(current version 0.9.1, released Nov 2022). I recommend switching
any `~>` constraints to `>=` unless there is a documented reason
not to.
@spilliams spilliams force-pushed the feature/DEVO-5179/time-outdated branch from 9a83bca to 4ac1c06 Compare October 10, 2023 16:55
@afiune afiune changed the title time provider outdated chore: update time provider to ~> 0.7 Oct 10, 2023
@afiune
Copy link
Contributor

afiune commented Oct 10, 2023

Make it so

@spilliams
Copy link
Contributor Author

@afiune did you intend to add a review to this PR? because it still needs a review before it can merge.

Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afiune
Copy link
Contributor

afiune commented Oct 20, 2023

@spilliams yes I did, and forgot. Here I am, back and ready to merge!

Thank you for your contribution. ❤️

@afiune afiune merged commit e947030 into lacework:main Oct 20, 2023
1 check passed
@spilliams spilliams deleted the feature/DEVO-5179/time-outdated branch October 23, 2023 15:57
@lacework-releng lacework-releng mentioned this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants