Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GROW-2791): v1 component JSON #1571

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

jon-stewart
Copy link
Contributor

Summary

Now have a CLI level componentJSON. We can change the underlying CDKComponent without breaking the JSON output.

I refactored parts of the code as a cleanup.

How did you test this change?

Unit testing

Local testing:

  • install, update, list, show, uninstall
  • dev mode new
  • dev mode enter existing
> bin/lacework component show component-example --json
{
  "deprecated": false,
  "description": "Component description",
  "latest_version": "0.9.1",
  "name": "component-example",
  "status": "Installed",
  "type": "CLI_COMMAND",
  "version": "0.9.1"
}

Issue

https://lacework.atlassian.net/browse/GROW-2791

@jon-stewart jon-stewart self-assigned this Feb 29, 2024
@jon-stewart jon-stewart requested a review from a team as a code owner February 29, 2024 21:01
Copy link
Contributor

@PengyuanZhao PengyuanZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jon-stewart jon-stewart force-pushed the jon-stewart/GROW-2791/component-json branch from fb85c07 to c546966 Compare March 1, 2024 16:06
@jon-stewart jon-stewart merged commit ac5fa63 into main Mar 1, 2024
11 checks passed
@jon-stewart jon-stewart deleted the jon-stewart/GROW-2791/component-json branch March 1, 2024 17:15
@lacework-releng lacework-releng mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants