Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check if cdk component is tainted #1412

Merged
merged 4 commits into from
Oct 16, 2023
Merged

feat: check if cdk component is tainted #1412

merged 4 commits into from
Oct 16, 2023

Conversation

PengyuanZhao
Copy link
Contributor

@PengyuanZhao PengyuanZhao commented Oct 13, 2023 •
edited
Loading

Summary

  • For the install and update command, if the specified version is tainted, then the command will fail by default. Nothing is changed.
  • For the list and show command, set the component status to "Tainted", displayed as "Tainted(Please update)", to prompt users to update.

How did you test this change?

lacework components list
Screenshot 2023-10-16 at 9 10 26 AM

lacework components show component-example
Screenshot 2023-10-16 at 9 10 36 AM

Issue

https://lacework.atlassian.net/browse/GROW-2367

@jon-stewart jon-stewart changed the title feat(GROW-2367): check if cdk component is tainted feat: check if cdk component is tainted Oct 13, 2023
jon-stewart
jon-stewart reviewed Oct 13, 2023
View reviewed changes
jon-stewart
jon-stewart approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@jon-stewart jon-stewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PengyuanZhao PengyuanZhao marked this pull request as ready for review October 16, 2023 13:13
@PengyuanZhao PengyuanZhao requested a review from a team as a code owner October 16, 2023 13:13
@PengyuanZhao PengyuanZhao merged commit 1cea71b into main Oct 16, 2023
@PengyuanZhao PengyuanZhao deleted the GROW-2367 branch October 16, 2023 13:14
@lacework-releng lacework-releng mentioned this pull request Oct 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jon-stewart jon-stewart jon-stewart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PengyuanZhao @jon-stewart