Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CDK bugs #1411

Merged
merged 1 commit into from
Oct 13, 2023
Merged

fix: CDK bugs #1411

merged 1 commit into from
Oct 13, 2023

Conversation

jon-stewart
Copy link
Contributor

Summary

  1. No components returned from the API would lead to a panic.
    Fix: safe array access

  2. No ~/.config/lacework/components directory would lead to an error
    Fix: create the dir if it doesn't exist

How did you test this change?

Local manual testing

@jon-stewart jon-stewart self-assigned this Oct 13, 2023
@jon-stewart jon-stewart requested a review from a team as a code owner October 13, 2023 13:02
@jon-stewart jon-stewart merged commit 93923cd into main Oct 13, 2023
@jon-stewart jon-stewart deleted the jon-stewart/fix-cdk-catalog branch October 13, 2023 13:08
Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make sure next changes come with tests?

@lacework-releng lacework-releng mentioned this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants