Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Falcon gas setup #5

Merged
merged 5 commits into from
Jul 31, 2023
Merged

Falcon gas setup #5

merged 5 commits into from
Jul 31, 2023

Conversation

eum602
Copy link
Member

@eum602 eum602 commented Jul 14, 2023 •
edited by diega
Loading

PR description

  • Add error handler in Falcon precompiled
  • Add benchmarks for Falcon512
  • Set Falcon precompiled gas cost based on benchmarks made in a modified Go-Ethereum client.

Fixed Issue(s)

@eum602 eum602 requested a review from diega July 14, 2023 17:15
diega
diega approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@diega diega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eum602 eum602 merged commit f8be293 into falcon_precompiled Jul 31, 2023
0 of 5 checks passed
@eum602 eum602 deleted the falcon_gas_setup branch July 31, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diega diega diega approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eum602 @diega