Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rate limiter docs #174

Merged
merged 4 commits into from
Jan 31, 2021

Conversation

iambenkay
Copy link
Contributor

Documentation for the rate limiter feature at echo@1724

@iambenkay
Copy link
Contributor Author

@lammel notice this line

If your app receives above 100 parallel requests at once then this might not be the best option

Is it safe to say that this is false considering your breakthrough with the middleware handling about 30,000 requests per sec conveniently?

@lammel
Copy link
Contributor

lammel commented Jan 8, 2021

@lammel notice this line

If your app receives above 100 parallel requests at once then this might not be the best option

Is it safe to say that this is false considering your breakthrough with the middleware handling about 30,000 requests per sec conveniently?

Not necessarily. Handling 30000 req/s sequentially is different compared to handling 300req/s in parallel from 100 sources (which my test uses). This is where lock contention comes in.
The number 100 is of course just a very vague estimate and shall only act as an indicator, that for high load traffic the builtin RateLimiterMemoryStore and ratelimiter might negatively influence performance of the app.

@lammel
Copy link
Contributor

lammel commented Jan 31, 2021

Thanks @iambenkay , adjusted some wordings and styling, think that's fine for now.

@lammel lammel merged commit 6491840 into labstack:master Jan 31, 2021
@lammel lammel mentioned this pull request Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants