Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix redirect middleware panicing on short host name (fix #1811) #1813

Merged

Conversation

aldas
Copy link
Contributor

@aldas aldas commented Mar 16, 2021

fix redirect middleware panicing on short host name (fix #1811)

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #1813 (e80c353) into master (dec96f0) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1813      +/-   ##
==========================================
+ Coverage   89.49%   89.71%   +0.21%     
==========================================
  Files          32       32              
  Lines        2685     2684       -1     
==========================================
+ Hits         2403     2408       +5     
+ Misses        181      178       -3     
+ Partials      101       98       -3     
Impacted Files Coverage Δ
middleware/redirect.go 100.00% <100.00%> (+15.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dec96f0...e80c353. Read the comment docs.

Copy link
Contributor

@lammel lammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.
Good to see more table driven tests too.

@lammel lammel added this to the v4.3 milestone Mar 17, 2021
@lammel lammel modified the milestones: v4.3, v4.2.2 Apr 6, 2021
@lammel lammel merged commit ae4665c into labstack:master Apr 6, 2021
@aldas aldas deleted the fix_1811_redirect_middleware_with_short_host branch May 23, 2021 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Middleware HTTPSNonWWWRedirect out of range 4
2 participants