Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic when a route is added with different path params #1762

Closed
wants to merge 3 commits into from
Closed

Panic when a route is added with different path params #1762

wants to merge 3 commits into from

Commits on Jan 27, 2021

  1. Panic when a route is added with different path params 

    From now, Echo panics if a route that was already added, is added again
but for a different HTTP method and the path params are different.
e.g.
GET /translation/:lang -> Added OK
PUT /translation/:lang -> Added OK
DELETE /translation/:id -> Panic

Partially Fixes labstack#1726 labstack#1744
    @pafuent
    pafuent committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    7ca4fd1 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2021

  1. Merge branch 'master' into router_different_params_same_route_differe… 

    …nt_method
    @pafuent
    pafuent committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    d891e60 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2021

  1. Adding Router interfaces 

    Also moving Route information from Echo to Router. This change also
enabled moving the Reverse method to the Router.
    @pafuent
    pafuent committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    c39feca View commit details
    Browse the repository at this point in the history