Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds middleware for rate limiting #1724

Merged
merged 40 commits into from
Jan 15, 2021
Merged

adds middleware for rate limiting #1724

merged 40 commits into from
Jan 15, 2021

Commits on Dec 17, 2020

  1. adds middleware for rate limiting

    @iambenkay
    iambenkay committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    180d26b View commit details
    Browse the repository at this point in the history

  2. added comment for InMemoryStore ShouldAllow

    @iambenkay
    iambenkay committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    dc04e2c View commit details
    Browse the repository at this point in the history

  3. removed redundant mutex declaration

    @iambenkay
    iambenkay committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    e0e9688 View commit details
    Browse the repository at this point in the history

  4. fixed lint issues

    @iambenkay
    iambenkay committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    ef2377c View commit details
    Browse the repository at this point in the history

  5. removed sleep from tests

    @iambenkay
    iambenkay committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    9b63f99 View commit details
    Browse the repository at this point in the history

  6. improved coverage

    @iambenkay
    iambenkay committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    34d9097 View commit details
    Browse the repository at this point in the history

  7. refactor: renames Identifiers, includes default SourceFunc

    @iambenkay
    iambenkay committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    02efca7 View commit details
    Browse the repository at this point in the history

  8. Added last seen stats for visitor

    @iambenkay
    iambenkay committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    8d34f11 View commit details
    Browse the repository at this point in the history

  9. uses http Constants for improved readdability 

    adds default error handler
    @iambenkay
    iambenkay committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    674665e View commit details
    Browse the repository at this point in the history

  10. used other handler apart from default handler to mark custom error ha… 

    …ndler for rate limiting
    @iambenkay
    iambenkay committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    018105b View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2020

  1. split tests into separate blocks 

    added an error pair to IdentifierExtractor
Includes deny handler for explicitly denying requests
    @iambenkay
    iambenkay committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    21fbfc8 View commit details
    Browse the repository at this point in the history

  2. adds comments for exported members Extractor and ErrorHandler

    @iambenkay
    iambenkay committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    2682655 View commit details
    Browse the repository at this point in the history

  3. adds cleanup method for stale visitors to RateLimiterMemoryStore

    @iambenkay
    iambenkay committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    8255716 View commit details
    Browse the repository at this point in the history

  4. makes cleanup implementation inhouse

    @iambenkay
    iambenkay committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    604c323 View commit details
    Browse the repository at this point in the history

  5. Avoid race for cleanup due to non-atomic access to store.expiresIn

    @lammel
    lammel committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    b5165d4 View commit details
    Browse the repository at this point in the history

  6. Use a dedicated producer for rate testing

    @lammel
    lammel committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    27e7115 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2020

  1. tidy commit

    @iambenkay
    iambenkay committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    56bf7a6 View commit details
    Browse the repository at this point in the history

  2. refactors tests, implicitly tests lastSeen property on visitor 

    switches NewRateLimiterMemoryStore constructor to Referential Functions style (Advised by @pafuent)
    @iambenkay
    iambenkay committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    24433cc View commit details
    Browse the repository at this point in the history

  3. switches to mock of time module for time based tests 

    tests are now fully deterministic
    @iambenkay
    iambenkay committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    76e3e89 View commit details
    Browse the repository at this point in the history

  4. improved coverage

    @iambenkay
    iambenkay committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    e7d1344 View commit details
    Browse the repository at this point in the history

  5. replaces Rob Pike referential options with more conventional struct c… 

    …onfigs

makes cleanup asynchronous
    @iambenkay
    iambenkay committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    049d21d View commit details
    Browse the repository at this point in the history

  6. blocks racy access to lastCleanup

    @iambenkay
    iambenkay committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    4326ec1 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2020

  1. Add benchmark tests for rate limiter

    @lammel
    lammel committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    1733765 View commit details
    Browse the repository at this point in the history

  2. Add rate limiter with sharded memory store

    @lammel
    lammel committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    4b3f2c8 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2020

  1. Racy access to store.lastCleanup eliminated 

    Merges in shiny sharded map implementation by @lammel
    @iambenkay
    iambenkay committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    3fffc7b View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2020

  1. Remove RateLimiterShradedMemoryStore for now

    @lammel
    lammel committed Dec 25, 2020
    Configuration menu
    Copy the full SHA
    f323d36 View commit details
    Browse the repository at this point in the history

  2. Make fields for RateLimiterStoreConfig public for external configuration

    @lammel
    lammel committed Dec 25, 2020
    Configuration menu
    Copy the full SHA
    59530a3 View commit details
    Browse the repository at this point in the history

  3. Improve docs for RateLimiter usage

    @lammel
    lammel committed Dec 25, 2020
    Configuration menu
    Copy the full SHA
    65b59c9 View commit details
    Browse the repository at this point in the history

  4. Fix ErrorHandler vs. DenyHandler usage for rate limiter

    @lammel
    lammel committed Dec 25, 2020
    Configuration menu
    Copy the full SHA
    e6371e2 View commit details
    Browse the repository at this point in the history

  5. Simplify NewRateLimiterMemoryStore

    @lammel
    lammel committed Dec 25, 2020
    Configuration menu
    Copy the full SHA
    1203b79 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2021

  1. improved coverage

    @iambenkay
    iambenkay committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    7d4566e View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2021

  1. updated errorHandler and denyHandler to use echo.HTTPError

    @iambenkay
    iambenkay committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    4e32a58 View commit details
    Browse the repository at this point in the history

  2. Improve wording for error and comments

    @lammel
    lammel committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    7dc77bb View commit details
    Browse the repository at this point in the history

  3. Remove duplicate lastSeen marking for Allow

    @lammel
    lammel committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    8c7eac7 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of github.com:iambenkay/echo into feature/rate-… 

    …limiter-middleware
    @iambenkay
    iambenkay committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    bcc7fe2 View commit details
    Browse the repository at this point in the history

  5. Improve wording for comments

    @lammel
    lammel committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    5374337 View commit details
    Browse the repository at this point in the history

  6. Add disclaimer on perf characteristics of memory store

    @lammel
    lammel committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    5f731d6 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'feature/rate-limiter-middleware' of https://github.com/… 

    …iambenkay/echo into feature/rate-limiter-middleware
    @lammel
    lammel committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    e58f4fd View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2021

  1. changes Allow signature on rate limiter to return err too

    @iambenkay
    iambenkay committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    d210158 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/rate-limiter-middleware' of github.com:iambenka… 

    …y/echo into feature/rate-limiter-middleware
    @iambenkay
    iambenkay committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    bbfb0ab View commit details
    Browse the repository at this point in the history