Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different pnames on one route support #1430

Closed
wants to merge 2 commits into from
Closed

Different pnames on one route support #1430

wants to merge 2 commits into from

Conversation

jerrdasur
Copy link

Convert node.pnames into structure for supporting different pnames on one route and different methods

#1306

@codecov
Copy link

codecov bot commented Oct 24, 2019

Codecov Report

Merging #1430 into master will increase coverage by 0.29%.
The diff coverage is 96.87%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1430      +/-   ##
=========================================
+ Coverage   84.11%   84.4%   +0.29%     
=========================================
  Files          27      27              
  Lines        2071    2123      +52     
=========================================
+ Hits         1742    1792      +50     
- Misses        214     216       +2     
  Partials      115     115
Impacted Files Coverage Δ
router.go 94.87% <96.87%> (+0.25%) ⬆️
bind.go 87.09% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 754b449...afe2d07. Read the comment docs.

@stale
Copy link

stale bot commented Dec 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant