fix(oss): fix error of setBucketPolicy api;

labring · Apr 15, 2022 · 8b5a2f0 · 8b5a2f0
1 parent b2151c0
commit 8b5a2f0
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 3 deletions.
diff --git a/packages/system-server/http/oss.http b/packages/system-server/http/oss.http
@@ -28,10 +28,22 @@ Authorization: Bearer {{token}}
 
 {
   "bucket": "test-for-create-bucket",
+  "mode": "private"
+}
+
+
+### Set bucket policy
+
+PUT  {{base_url}}/sys-api/apps/{{appid}}/oss/buckets/test-for-create-bucket
+Authorization: Bearer {{token}}
+Content-Type: application/json
+
+{
   "mode": "public-read"
 }
 
 
+
 ### Delete a bucket
 
 DELETE  {{base_url}}/sys-api/apps/{{appid}}/oss/buckets/test-for-create-bucket

diff --git a/packages/system-server/src/router/oss/delete-bucket.ts b/packages/system-server/src/router/oss/delete-bucket.ts
@@ -32,7 +32,7 @@ export async function handleDeleteBucket(req: Request, res: Response) {
   const internalName = `${app.appid}-${bucketName}`
   const ret = await oss.deleteBucket(internalName)
   if (ret?.$metadata?.httpStatusCode !== 204) {
-    return res.send(ret?.$metadata)
+    return res.send({ code: 'ERROR', data: ret?.$metadata})
   }
 
   // delete bucket from app

diff --git a/packages/system-server/src/router/oss/update-bucket.ts b/packages/system-server/src/router/oss/update-bucket.ts
@@ -41,8 +41,8 @@ export async function handleSetBucketPolicy(req: Request, res: Response) {
   const oss = await MinioAgent.New()
   const internalName = `${app.appid}-${bucketName}`
   const ret = await oss.setBucketACL(internalName, mode)
-  if (ret?.$metadata?.httpStatusCode !== 200) {
-    return res.send(ret?.$metadata)
+  if (ret?.$metadata?.httpStatusCode !== 204) {
+    return res.send({ code: 'ERROR', data: ret?.$metadata})
   }
 
   // update bucket to app