861 - The component does not have a red border #862
Conversation
| @@ -13,7 +13,7 @@ export function MonthRangePickerInput(props: MonthRangePickerInputProps) { | |||
|
|
|||
| return ( | |||
| <FormControl {...getFormControlProps()}> | |||
| <BaseMonthRangeInput {...inputProps} {...rest} /> | |||
| <BaseMonthRangeInput invalid={inputProps['aria-invalid']} {...inputProps} {...rest} /> | |||
There was a problem hiding this comment.
Does the aria-invalid property need to remain in inputProps, since it has already been used elsewhere?
There was a problem hiding this comment.
It's a hook's result and this hook is used everywhere, so i think it's not a good idea to remove from useFormControl
There was a problem hiding this comment.
Yes, I meant to just stop passing it to the BaseMonthRangeInput component, since it's already being passed to the invalid prop.
There was a problem hiding this comment.
Oh, now i understand hehe
| export const MinMax = () => { | ||
| const [range, setRange] = useState<ReferenceMonthRange>(initialValue) | ||
|
|
||
| const handleChange = (dateRange: DateRange) => { |
There was a problem hiding this comment.
| const handleChange = (dateRange: DateRange) => { | |
| const handleRangeChange = (setRange) => (dateRange: DateRange) => { |
You could declare this function at the file scope and reuse it within the component scope
| @@ -13,7 +13,7 @@ export function MonthRangePickerInput(props: MonthRangePickerInputProps) { | |||
|
|
|||
| return ( | |||
| <FormControl {...getFormControlProps()}> | |||
| <BaseMonthRangeInput {...inputProps} {...rest} /> | |||
| <BaseMonthRangeInput invalid={inputProps['aria-invalid']} {...inputProps} {...rest} /> | |||
There was a problem hiding this comment.
Yes, I meant to just stop passing it to the BaseMonthRangeInput component, since it's already being passed to the invalid prop.
closes #861