Hcurl changes #189
Merged
Hcurl changes #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orlandini
force-pushed
the
hcurl-changes
branch
from
5c6d525
to
0333739
Compare
orlandini
requested review from
philippedevloo,
nathanshauer and
giavancini
we need to ensure that h.o. edge funcs are pure gradients
we want to ensure that they are pure gradients
orlandini
force-pushed
the
hcurl-changes
branch
from
0333739
to
93aaa01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR concerns changes in the construction of HCurl-conforming approximation spaces.
Apart from some speedup/optimizations regarding dynamic memory allocation,
some relevant changes were made:
The edge functions for hcurl elements now consist of the lowest order edge functions (constant tangential trace) and gradient of H1 edge functions.
While the previous approach did contain the necessary gradients, there were also undesired solenoidal terms which would strongly affect the performance of some preconditioners.