Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(BA-432): Enforce VFolder name length restriction through the API schema #3363

Merged
merged 17 commits into from
Jan 9, 2025
Merged

fix(BA-432): Enforce VFolder name length restriction through the API schema #3363

merged 17 commits into from
Jan 9, 2025
+161 −44

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Jan 4, 2025 •
edited by github-actions bot
Loading

resolves #3334

Enforce VFolder name length restriction through the API schema, not by the DB column constraint.

  • Increase the length constraint of the vfolders.name column from 64 to 128.
  • Set the maximum length of the VFolder name to 64 characters in the create/rename API.
  • Refactor the VFolder create/rename API schema definition using Pydantic models.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation

📚 Documentation preview 📚: https://sorna--3363.org.readthedocs.build/en/3363/

📚 Documentation preview 📚: https://sorna-ko--3363.org.readthedocs.build/ko/3363/

@fregataa fregataa added this to the 25Q1 milestone Jan 4, 2025
@fregataa fregataa self-assigned this Jan 4, 2025
@github-actions github-actions bot added area:docs Documentations comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated size:M 30~100 LoC labels Jan 4, 2025
@fregataa fregataa requested a review from HyeockJinKim January 4, 2025 03:51
@github-actions github-actions bot added comp:common Related to Common component size:L 100~500 LoC and removed size:M 30~100 LoC labels Jan 4, 2025
@fregataa fregataa modified the milestones: 25Q1, 24.03 Jan 7, 2025
@fregataa fregataa requested a review from HyeockJinKim January 9, 2025 03:27
HyeockJinKim
HyeockJinKim approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@HyeockJinKim HyeockJinKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@HyeockJinKim HyeockJinKim added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit 94a0c3e Jan 9, 2025
23 checks passed
@HyeockJinKim HyeockJinKim deleted the fix/allow-deleting-long-named-vfolders branch January 9, 2025 04:52
lablup-octodog pushed a commit that referenced this pull request Jan 9, 2025
@fregataa
fix(BA-432): Enforce VFolder name length restriction through the API …
1344347 
…schema (#3363)

Backported-from: main (24.12)
Backported-to: 24.09
Backport-of: 3363
@lablup-octodog lablup-octodog mentioned this pull request Jan 9, 2025
Merged
lablup-octodog pushed a commit that referenced this pull request Jan 9, 2025
@fregataa
fix(BA-432): Enforce VFolder name length restriction through the API …
e869dcc 
…schema (#3363)

Backported-from: main (24.12)
Backported-to: 24.03
Backport-of: 3363
@lablup-octodog lablup-octodog mentioned this pull request Jan 9, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 9, 2025
@lablup-octodog @fregataa
fix(BA-432): Enforce VFolder name length restriction through the API …
7abc8d6 
…schema (#3363) (#3415)

Co-authored-by: Sanghun Lee <sanghun@lablup.com>
github-merge-queue bot pushed a commit that referenced this pull request Jan 9, 2025
@lablup-octodog @fregataa
fix(BA-432): Enforce VFolder name length restriction through the API …
157eb02 
…schema (#3363) (#3416)

Co-authored-by: Sanghun Lee <sanghun@lablup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyeockJinKim HyeockJinKim HyeockJinKim approved these changes

Assignees

@fregataa fregataa

Labels
area:docs Documentations comp:common Related to Common component comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated size:L 100~500 LoC
Projects
None yet
Milestone
24.03
Development

Successfully merging this pull request may close these issues.

Allow Deletion of Vfolders with Names Longer Than 40 Characters
2 participants
@fregataa @HyeockJinKim