-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(BA-435): Implement GQL for querying and modifying AbusingReportConfig
#3355
Draft
jopemachine
wants to merge
12
commits into
main
Choose a base branch
from
implement_abuse_report_gql
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:docs
Documentations
comp:manager
Related to Manager component
comp:agent
Related to Agent component
size:M
30~100 LoC
labels
Jan 3, 2025
Co-authored-by: octodog <mu001@lablup.com>
jopemachine
changed the title
feat: Implement
feat(BA-435): Implement Jan 3, 2025
AbusingReportConfig
GQLAbusingReportConfig
GQL
github-actions
bot
added
comp:common
Related to Common component
size:L
100~500 LoC
and removed
size:M
30~100 LoC
labels
Jan 7, 2025
jopemachine
changed the title
feat(BA-435): Implement
feat(BA-435): Implement GQL for querying and modifying Jan 7, 2025
AbusingReportConfig
GQLAbusingReportConfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:docs
Documentations
comp:agent
Related to Agent component
comp:common
Related to Common component
comp:manager
Related to Manager component
size:L
100~500 LoC
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to resolve #3342 (BA-435).
How it works
In the case of configuration change mutations, only specific settings are modified through an RPC call named
set_local_config
.The agent called via
set_local_config
updates its in-memorylocal_config
and also updates theagent.toml
file to ensure that the changed settings are retained even after a reboot.Considerations
Note
Please note that settings used in initialization logic will not be applied immediately.
For example, in the case of
modify_abusing_report_config
, the initialization logic inAbstractAgent.__ainit__()
that recursively creates the folder if theabuse-report-path
does not exist will not be executed. Therefore, the directory forabuse-report-path
must already exist.Query example
Mutation example
Checklist: (if applicable)
📚 Documentation preview 📚: https://sorna--3355.org.readthedocs.build/en/3355/
📚 Documentation preview 📚: https://sorna-ko--3355.org.readthedocs.build/ko/3355/