-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(BA-96): metric based model service autoscaling #3277
Open
kyujin-cho
wants to merge
46
commits into
main
Choose a base branch
from
feature/model-service-autoscale
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:docs
Documentations
comp:manager
Related to Manager component
require:db-migration
Automatically set when alembic migrations are added or updated
labels
Dec 19, 2024
kyujin-cho
added
type:feature
Add new features
and removed
area:docs
Documentations
comp:manager
Related to Manager component
require:db-migration
Automatically set when alembic migrations are added or updated
labels
Dec 19, 2024
github-actions
bot
added
size:L
100~500 LoC
comp:agent
Related to Agent component
comp:appproxy
Related to App Proxy component
comp:manager
Related to Manager component
urgency:5
It is imperative that action be taken right away.
labels
Dec 19, 2024
kyujin-cho
changed the title
feature: model service autoscaling
feat: model service autoscaling
Dec 19, 2024
kyujin-cho
changed the title
feat: model service autoscaling
feat: metric based model service autoscaling
Dec 19, 2024
kyujin-cho
force-pushed
the
feature/model-service-autoscale
branch
from
December 20, 2024 12:12
2e9102e
to
9bc0661
Compare
Co-authored-by: octodog <mu001@lablup.com>
Co-authored-by: octodog <mu001@lablup.com>
achimnol
requested changes
Dec 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
achimnol
requested changes
Dec 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github-actions
bot
added
comp:client
Related to Client component
comp:common
Related to Common component
comp:cli
Related to CLI component
labels
Jan 2, 2025
Co-authored-by: octodog <mu001@lablup.com>
Co-authored-by: octodog <mu001@lablup.com>
Co-authored-by: octodog <mu001@lablup.com>
Could you review it again? @achimnol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:docs
Documentations
comp:agent
Related to Agent component
comp:appproxy
Related to App Proxy component
comp:cli
Related to CLI component
comp:client
Related to Client component
comp:common
Related to Common component
comp:manager
Related to Manager component
require:db-migration
Automatically set when alembic migrations are added or updated
size:XL
500~ LoC
type:feature
Add new features
urgency:blocker
IT SHOULD BE RESOLVED BEFORE NEXT RELEASE!
urgency:5
It is imperative that action be taken right away.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2659 (BA-96)
What's changed
endpoint_auto_scaling_rules
table addedscale_services()
which automatically increases or decreasesEndpointRow.replicas
factors based on the rules definedEndpointStatistics
andKernelStatistics
so that bulk loader can be reused internallyHow it works
cuda.shares
orvllm_avg_prompt_throughput_toks_per_s
)LESS_THAN
: Rule triggered when current metric value goes below the threshold definedLESS_THAN_OR_EQUAL
: Rule triggered when current metric value goes below or equals the threshold definedGREATER_THAN
: Rule triggered when current metric value goes above the threshold definedGREATER_THAN_OR_EQUAL
: Rule triggered when current metric value goes above or equals the threshold definedChecklist: (if applicable)
📚 Documentation preview 📚: https://sorna--3277.org.readthedocs.build/en/3277/
📚 Documentation preview 📚: https://sorna-ko--3277.org.readthedocs.build/ko/3277/