Fix: Using set sometimes gets Helm provider confused

[roni-frantchi]

There are several reports of unresolved issues when using the set block of helm provider, see:

• .version field causes Error: Provider produced inconsistent final plan hashicorp/terraform-provider-helm#476
• 'Provider produced inconsistent final plan' error after apply  hashicorp/terraform-provider-helm#711

I have encountered this issue when using this module as well and using var.settings to set values.

When passing values via the values attribute of helm provider, these seem to go away.
This PR adds the ability to do so, while keeping settings for backwards compatibility.

[martinhaus]

Hi, @roni-frantchi,
thanks for the PR. This issue is caused by the Helm provider, not the module itself. I still think we can add the ability to pass values through a variable as long as we also keep the option to use --set.

Can you please update the readme to reflect your changes and also please squash your commits so the PR has a meaningful commit history? We can merge it after that

[roni-frantchi]

Thanks @martinhaus - I've updated the description in readme file to match that of the Terraform value.
Let me know if that makes sense - any suggestions are welcome

[martinhaus]

@roni-frantchi thanks, can you update the readme to the same format as the variable description? The additional formatting causes the tf-docs check to fail.

[martinhaus]

@roni-frantchi there's still an formatting issue. You've put additional " in there. Try running the precommit hooks locally to verify your commits

[roni-frantchi]

Thanks for merging @martinhaus !
Any chance we can get a release out?

[martinhaus]

Yes, done