522 proposal add active flag to shipping method #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demeyerthom
requested changes
Dec 3, 2024
There was a problem hiding this comment.
@gasttor looks good! Added one tiny comment about the changelog
demeyerthom
approved these changes
Dec 3, 2024
|
Hi @demeyerthom, File: docs/resources/shipping_method.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commercetools enhanced the ShippingMethod with an active flag. This PR introduces this attribute to the appropriate resource within the terraform provider.
Commercetools API: https://docs.commercetools.com/api/projects/shippingMethods#shippingmethod
Fixes #522
NEW FEATURES | UPGRADE NOTES | ENHANCEMENTS | BUG FIXES | EXPERIMENTS
I added the attribute ShippingMethod.active to the resource shipping_method, so that it can be set via terraform.