Integration of Karma testing framework #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, I added a test for the Viewer so that one can actually see that the WebGL stuff works with |
Luthaf
reviewed
Jul 9, 2021
Co-authored-by: Guillaume Fraux <luthaf@luthaf.fr>
Co-authored-by: Guillaume Fraux <luthaf@luthaf.fr>
…a/chemiscope into karma-testing-framework
|
I have an issue when trying to run the tests locally: I'd guess this is related to webpack or karma configuration, I'll check what's going on |
Luthaf
reviewed
Jul 13, 2021
package.json
Outdated
| "karma-firefox-launcher": "^2.1.1", | ||
| "karma-mocha": "^2.0.1", | ||
| "karma-safari-launcher": "^1.0.0", | ||
| "karma-webpack": "git+https://github.com/ryanclark/karma-webpack#ef7edb6b6756fb563871eaff88ca876892694896", |
There was a problem hiding this comment.
I had to use the latest master commit, since it contains some un-released changes that fix another issue I had with karma-webpack (codymikol/karma-webpack#453 (comment))
There was a problem hiding this comment.
incredibly, works on my system
…a/chemiscope into karma-testing-framework
Luthaf
force-pushed
the
karma-testing-framework
branch
from
4990991
to
d32cc1f
Compare
Luthaf
force-pushed
the
karma-testing-framework
branch
from
d32cc1f
to
a81df98
Compare
Luthaf
force-pushed
the
karma-testing-framework
branch
from
59e91f0
to
501f130
Compare
|
I though I already merged this 😄 Well, now it is done! |
jakublala
added a commit
to jakublala/chemiscope
that referenced
this pull request
Jul 21, 2021
author Jakub Lála <68380659+jakublala@users.noreply.github.com> 1626864006 +0200 committer Jakub Lála <jakublala@gmail.com> 1626892362 +0200 parent 9eacadc author Jakub Lála <68380659+jakublala@users.noreply.github.com> 1626864006 +0200 committer Jakub Lála <jakublala@gmail.com> 1626892347 +0200 parent 9eacadc author Jakub Lála <68380659+jakublala@users.noreply.github.com> 1626864006 +0200 committer Jakub Lála <jakublala@gmail.com> 1626892324 +0200 Use Karma to run unit tests (lab-cosmo#173) Previously tests would run on node, and we would mimic a browser environment with JSDom, but the limitations of this approach were too big. Karma allows to run the tests in real browsers, which is where chemiscope runs in practice Temp Commit Changed .gitIgnore temp commit temp commit Added Karma Viewer test added Remove coverage files Moved files / Changed chrome launcher setup-chrome driver attempt Revert previosu commit Update .github/workflows/tests.yml Co-authored-by: Guillaume Fraux <luthaf@luthaf.fr> Enacted on suggestions Day 1 commit temp commit Added a few unit tests for Map Options One more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrating
karmainstead ofjsdomto actually run the tests in a browser so that WebGL works (and one can thus write tests for the Viewer or the Map).