Fixes with CEQ 3.2.0 #291
Fixes with CEQ 3.2.0 #291
Conversation
zhfeng
force-pushed
the
fixes_in_3.2.0
branch
from
6592274 to
72cd078
Compare
|
|
||
| /* Add integration-tests/message module */ | ||
| getLog().info("Adding to pom.xml: integration-tests/messaging module"); | ||
| modules.addChildTextElement("module", "integration-tests/messaging"); |
There was a problem hiding this comment.
I wonder why we need to add <module>integration-tests/messaging</messaging> to the root pom.xml?
There was a problem hiding this comment.
Well, it looks like a work around.
The org.apache.camel.quarkus:camel-quarkus-integration-test-messaging-jms should be set with ${camel-quarkus-community.version} but this does not happen when running with cq:prod-excludes.
If we find a fix, it should be removed.
There was a problem hiding this comment.
OK, I think I find a cause. Let's take a look at og.apache.camel.quarkus:camel-quarkus-integration-test-jms-artemis-client dependencies filtered by camel-quarkus extensions:
[INFO] contains org.apache.camel.quarkus:camel-quarkus-core
[INFO] contains org.apache.camel.quarkus:camel-quarkus-jms
[INFO] contains org.apache.camel.quarkus:camel-quarkus-support-spring
[INFO] contains org.apache.camel.quarkus:camel-quarkus-bean
[INFO] contains org.apache.camel.quarkus:camel-quarkus-jta
[INFO] contains org.apache.camel.quarkus:camel-quarkus-mock
[INFO] contains org.apache.camel.quarkus:camel-quarkus-xml-jaxp
[INFO] contains org.apache.camel.quarkus:camel-quarkus-support-commons-logging
[INFO] contains org.apache.camel.quarkus:camel-quarkus-direct
Then all of them haven been productized. We introduce camel-quarkus-xml-jaxp in 3.2.0 recently. So the jms-artemis-client test is taken into TestCategory.PURE_PRODUCT. Now we have to product org.apache.camel.quarkus:camel-quarkus-integration-test-messaging-jms as a transitive dependency.
That could be the reason it keeps ${camel-quarkus.version} in the poms/bom-test/pom.xml.
There was a problem hiding this comment.
If it really solves some problem, it is fine to leave it there. Anyway it would be nice to add a comment explaining the motivation.
zhfeng
force-pushed
the
fixes_in_3.2.0
branch
from
72cd078 to
0b108f4
Compare
No description provided.