Deployments should respect serviceAccount.autmount value in Helm chart #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 12, 2024 15:40
Signed-off-by: Vidar Anima Normann <vidar-anima.normann@soprasteria.com>
Signed-off-by: Vidar Anima Normann <vidar-anima.normann@soprasteria.com>
…or ui, kyverno-plugin and trivy-plugin Signed-off-by: Vidar Anima Normann <vidar-anima.normann@soprasteria.com>
fjogeleit
reviewed
Nov 12, 2024
fjogeleit
reviewed
Nov 12, 2024
charts/policy-reporter/templates/plugins/kyverno/deployment.yaml
Outdated
Show resolved
Hide resolved
Pull Request Test Coverage Report for Build 11812199403Details
💛 - Coveralls |
…vy plugins Signed-off-by: Vidar Anima Normann <vidar-anima.normann@soprasteria.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deployment for policy-reporter had hardcoded automountServiceAccountToken and never used serviceAccount.automount at all.
In addition the ui, kyverno-plugin and trivy-plugin used their corresponding value only in the ServiceAccount-resource - this Pull Request configures their respective Deployments to also use the serviceAccount.automount.