Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix duplicate Service name in a manifest #385

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

hhsel
Copy link
Contributor

@hhsel hhsel commented Dec 28, 2023

Fixes #384

@fjogeleit
Copy link
Member

Thanks for your contribution. Could you please sign your commit e.g.

git commit -m "fix duplicate Service name in a manifest" -s

to fulfill the DCO check.

Signed-off-by: H.HSEL <26063868+hhsel@users.noreply.github.com>
@hhsel hhsel force-pushed the fix-duplicate-service-name branch from 78c7eaa to 469315a Compare December 28, 2023 12:33
@hhsel
Copy link
Contributor Author

hhsel commented Dec 28, 2023

sorry I missed that, now corrected.

@fjogeleit fjogeleit merged commit bf13160 into kyverno:main Dec 28, 2023
3 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7347639115

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.999%

Totals Coverage Status
Change from base Build 7220615642: 0.0%
Covered Lines: 4542
Relevant Lines: 4937

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate Service name in a manifest file
3 participants