Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add elastic search api key authentication #379

Merged

Conversation

guipal
Copy link
Contributor

@guipal guipal commented Dec 11, 2023

Add apiKey authentication method to elasticSearch target

Problem

Currently, the only available method to authenticate elasticSearch target is by using username/password in a Basic Http Auth Method.
This is a limitation and implies using login credentials from a user in the integration

Proposed Implementation

Adding the possibility to configure ApiKey authentication so the integration can be achieved by using an user personal apiKey instead of actual user credentials.

@fjogeleit
Copy link
Member

thanks for your contribution.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7167601966

  • 10 of 11 (90.91%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 91.999%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/target/elasticsearch/elasticsearch.go 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
pkg/target/elasticsearch/elasticsearch.go 1 91.11%
Totals Coverage Status
Change from base Build 7158161642: 0.02%
Covered Lines: 4542
Relevant Lines: 4937

💛 - Coveralls

@fjogeleit fjogeleit merged commit a0bd98a into kyverno:main Dec 11, 2023
2 of 3 checks passed
@guipal guipal deleted the feat/add-elasticSearch-apiKey-authentication branch December 11, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants