Fix AWS target check (#347)

Signed-off-by: Frank Jogeleit <frank.jogeleit@web.de>
kyverno · Oct 12, 2023 · 9036018 · 9036018
1 parent f0894c0
commit 9036018
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/pkg/config/target_factory.go b/pkg/config/target_factory.go
@@ -598,7 +598,7 @@ func (f *TargetFactory) createS3Client(config, parent *S3) target.Client {
 	}
 
 	config.MapAWSParent(parent.AWSConfig)
-	if config.Endpoint == "" {
+	if config.Endpoint == "" && !hasAWSIdentity() {
 		return nil
 	}
 
@@ -902,11 +902,15 @@ func NewTargetFactory(secretClient secrets.Client) *TargetFactory {
 	return &TargetFactory{secretClient: secretClient}
 }
 
-func checkAWSConfig(name string, config AWSConfig, parent AWSConfig) error {
+func hasAWSIdentity() bool {
 	arn := os.Getenv("AWS_ROLE_ARN")
 	file := os.Getenv("AWS_WEB_IDENTITY_TOKEN_FILE")
 
-	noEnvConfig := arn == "" && file == ""
+	return arn != "" && file != ""
+}
+
+func checkAWSConfig(name string, config AWSConfig, parent AWSConfig) error {
+	noEnvConfig := !hasAWSIdentity()
 
 	if noEnvConfig && (config.AccessKeyID == "" && parent.AccessKeyID == "") {
 		return fmt.Errorf("%s.AccessKeyID has not been declared", name)