Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Client Side Batching #122

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Remove Client Side Batching #122

merged 2 commits into from
Aug 12, 2024

Conversation

Ktmi
Copy link
Contributor

@Ktmi Ktmi commented Aug 8, 2024

Closes #47

Summary

Removes client side batching.

Local Tests

Not something I can truly test beyond making sure that flow mods are sent when expected, which they still seem to be.

@Ktmi Ktmi requested a review from a team as a code owner August 8, 2024 20:04
Copy link
Member

@viniarck viniarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Leaving it pre-approved.

Before merging @Ktmi, this needs to be updated the changelog since it's a breaking change on this NApp settings, users need to know that now this configuration is done on flow_manager.

@Ktmi Ktmi merged commit cce0f42 into master Aug 12, 2024
1 check passed
@Ktmi Ktmi deleted the remove/batching branch August 12, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: replace client side batched events by parametrizing batch_size and batch_interval
2 participants