Added feature to avoid tags when selecting s_vlan
#517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viniarck
reviewed
Nov 21, 2024
There was a problem hiding this comment.
Looks good to me. Left a minor naming suggestion and docstring.
Other than that, this change also deserves to be in the changelog since it's a new sub-feature that's being exposed allowing NApps to try to avoid a given tag value when getting the next link tag.
- Change parameter avoid_tag: TAG to try_avoid_value: int.
viniarck
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Nicely done @Alopalao, before merging, in the changelog, if you can still keep the information about the last tag feature that'd be great. Looks like you meant to only augment that line, but it deleted prior important information.
This was referenced Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #516
Summary
Added argument to accept a TAG to be avoided.
Local Tests
Tested with calling
link.get_next_available_tag(controller, link.id, avoid_tag=tag)on Kytos console.Added unit test to cover all possible scenarios.
End-to-End Tests
N/A