Add in configuration for event buffers #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viniarck
reviewed
Jan 12, 2024
There was a problem hiding this comment.
Overall looks good. This unblocks other tasks, I'll keep using the feat/event_buffer_config as a base branch for upcoming PRs. @Ktmi, before this lands, unit tests needs to be included too, and also changelog needs to be updated.
viniarck
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in configuration options for event buffers. This is based on the configuration that #412 had implemented, but removes rate limiting.
Local Tests
Everything appears to work as expected, with the only real difference being the ability to configure through the kytos.conf file.