Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nulls not distinct option #770

Merged
merged 18 commits into from
Nov 21, 2023
Merged

Nulls not distinct option #770

merged 18 commits into from
Nov 21, 2023

Conversation

viraxslot
Copy link
Contributor

@viraxslot viraxslot commented Nov 19, 2023 •
edited
Loading

Closes: #711

Modifier "nulls not distincts" added to:

  • CREATE TABLE - ADD COLUMN
  • CREATE TABLE - ADD UNIQUE CONSTRAINT
  • CREATE INDEX
  • ALTER TABLE - ADD COLUMN
  • ALTER TABLE - ADD UNIQUE CONSTRAINT

Also:

  • added unit tests
  • added docs description

@vercel Vercel
Copy link

vercel bot commented Nov 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kysely ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 1:04am

@viraxslot
Copy link
Contributor Author

@koskimas @igalklebanov Hi, this is my first pull request here and it's still in progress. Could you please review to ensure I'm heading in the right direction? I've added a new option to addUniqueConstraint because it seemed a bit challenging to modify a constraint once it's already been added (or perhaps I just didn't find a way to do so). Also, I've changed the documentation on the site, as I couldn't find an example of createTable when I needed it personally.

I'll willingly make any changes. Thanks!

@viraxslot viraxslot marked this pull request as draft November 19, 2023 02:27
@viraxslot
Copy link
Contributor Author

@igalklebanov Thanks for your comments. Implemented/fixed everything, ready to review.

@viraxslot viraxslot marked this pull request as ready for review November 19, 2023 20:57
@viraxslot viraxslot changed the title [WIP] Nulls not distinct option Nulls not distinct option Nov 19, 2023
@igalklebanov
Update src/query-compiler/default-query-compiler.ts
5d8d60c 
Co-authored-by: Igal Klebanov <igalklebanov@gmail.com>
igalklebanov
igalklebanov approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@igalklebanov igalklebanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💪

@igalklebanov igalklebanov merged commit 4e40aa8 into kysely-org:master Nov 21, 2023
4 checks passed
@viraxslot viraxslot deleted the nulls-not-distinct branch November 21, 2023 10:10
@filipeoliveiraa filipeoliveiraa mentioned this pull request Aug 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalklebanov igalklebanov igalklebanov approved these changes

Assignees
No one assigned
Labels
api Related to library's API enhancement New feature or request postgres Related to PostgreSQL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "NULLS NOT DISTINCT" support
2 participants
@viraxslot @igalklebanov