fix(inserts): resolve issues with undefined values

kysely-org · Jan 5, 2025 · 15bcf77 · 15bcf77
1 parent 67e413e
commit 15bcf77
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/src/parser/insert-values-parser.ts b/src/parser/insert-values-parser.ts
@@ -80,7 +80,7 @@ function parseColumnNamesAndIndexes(
     const cols = Object.keys(row)
 
     for (const col of cols) {
-      if (!columns.has(col) && row[col] !== undefined) {
+      if (!columns.has(col)) {
         columns.set(col, columns.size)
       }
     }

diff --git a/test/node/src/insert.test.ts b/test/node/src/insert.test.ts
@@ -729,7 +729,7 @@ for (const dialect of DIALECTS) {
         {
           first_name: 'Foo',
           last_name: 'Spam',
-          middle_name: 'Bo',
+          middle_name: undefined,
           gender: 'other',
         },
         {
@@ -742,20 +742,20 @@ for (const dialect of DIALECTS) {
 
       testSql(query, dialect, {
         postgres: {
-          sql: 'insert into "person" ("first_name", "last_name", "middle_name", "gender") values ($1, $2, $3, $4), ($5, default, default, $6)',
-          parameters: ['Foo', 'Spam', 'Bo', 'other', 'Baz', 'other'],
+          sql: 'insert into "person" ("first_name", "last_name", "middle_name", "gender") values ($1, $2, default, $3), ($4, default, default, $5)',
+          parameters: ['Foo', 'Spam', 'other', 'Baz', 'other'],
         },
         mysql: {
-          sql: 'insert into `person` (`first_name`, `last_name`, `middle_name`, `gender`) values (?, ?, ?, ?), (?, default, default, ?)',
-          parameters: ['Foo', 'Spam', 'Bo', 'other', 'Baz', 'other'],
+          sql: 'insert into `person` (`first_name`, `last_name`, `middle_name`, `gender`) values (?, ?, default, ?), (?, default, default, ?)',
+          parameters: ['Foo', 'Spam', 'other', 'Baz', 'other'],
         },
         mssql: {
-          sql: 'insert into "person" ("first_name", "last_name", "middle_name", "gender") values (@1, @2, @3, @4), (@5, default, default, @6)',
-          parameters: ['Foo', 'Spam', 'Bo', 'other', 'Baz', 'other'],
+          sql: 'insert into "person" ("first_name", "last_name", "middle_name", "gender") values (@1, @2, default, @3), (@4, default, default, @5)',
+          parameters: ['Foo', 'Spam', 'other', 'Baz', 'other'],
         },
         sqlite: {
-          sql: 'insert into "person" ("first_name", "last_name", "middle_name", "gender") values (?, ?, ?, ?), (?, null, null, ?)',
-          parameters: ['Foo', 'Spam', 'Bo', 'other', 'Baz', 'other'],
+          sql: 'insert into "person" ("first_name", "last_name", "middle_name", "gender") values (?, ?, null, ?), (?, null, null, ?)',
+          parameters: ['Foo', 'Spam', 'other', 'Baz', 'other'],
         },
       })