-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wallet: batch bulk actions #546
Conversation
GitHub build for this branch (Windows and Linux) for anyone who wants to try it out: https://github.com/rithvikvibhu/bob-wallet/actions/runs/3083707779 |
Solve: Method not found: sendbatchI encountered inconsistency in my wallet history, so I tried to secure and Transfer all my TLDs into new Seedphrase wallet. Solution1.) Download the source code for batching 2.) Extract, execute 3.) Build, execute 4.) Run the software located in release/ |
30dcedf
to
f6d87a0
Compare
Go for it. Been testing it with its max N and its great! It would be cool for Bob with multisig and batching features release! |
Also update 2 months to match hsd's 3 months
f6d87a0
to
7f88e9a
Compare
Closes #398 (better handling this time) and other issues which don't have GitHub issues (described below).
1. Consider pending transactions for stats
When calculating balance and cards, use
getUnspentCoin
so that pending txs don't conflict with bulk actions.Ex: Reveal All would not work if there is a bid revealed but not yet confirmed.
2. Find renewable names based on height, not time
This is to match hsd's condition. Also update 2 months to match hsd's 3 months
3. Use batching for bulk actions
Major part of this PR. It replaces registerAll, transferMany, revealAll and redeemAll with hsd's equivalent batch rpc calls. Similarly adds finalizeAll and renewAll.
Until now, all the *All functions would create large (invalid) transactions if there were many bids or names (a few hundred+). With batching, these are broken up into multiple smaller transactions.
This behaviour is slightly different with Ledger wallets:
Tested with both regular wallets and Ledger wallets.
For reviewers: be sure to run
npm install
as this currently requires handshake-org/hsd#764You can use this script to create a lot of opens and place bids: https://gist.github.com/rithvikvibhu/9f891202a430a50af3a1cc6375f0dfe3
h/t to @pinheadmz for adding batch to hsd!
To do: