Rewrite Gatsby API from gatsby folder to TS #369
Conversation
magicmatatjahu
added
the
kind/feature
magicmatatjahu
requested review from
aerfio,
derberg,
m00g3n and
hudymi
as code owners
|
Deploy preview ready! ( ͡° ͜ʖ ͡°) Built with commit c43443d |
magicmatatjahu
added
the
area/core-and-supporting
| @@ -132,8 +134,7 @@ | |||
| "git add" | |||
| ], | |||
| "src/**/*.{ts,tsx}": [ | |||
| "tslint -c tslint.json --project tsconfig.json --format verbose --fix", | |||
| "prettier --config .prettierrc --write", | |||
| "npm run lint-fix", | |||
There was a problem hiding this comment.
npm run lint-fix does not accept arguments, it's just a command. previous instruction lints just those files that are commited
There was a problem hiding this comment.
npm run lint-fix is short command of tslint and pretiier, so I think it works like with options.
| options: { | ||
| source: `${__dirname}/../../content`, | ||
| destination: "/assets", | ||
| extensions: ["jpeg", "jpg", "gif", "png", "svg", "json", "yaml", "yml"], |
There was a problem hiding this comment.
We use it in one place, so extracting is unnecessary.
| interface OnCreateDocsNode { | ||
| node: Node; | ||
| relativePath: string; | ||
| createNodeField: Function; |
|
|
||
| module.exports = async ({ graphql, createPage, createRedirect }) => { | ||
| export const getPosts = async (graphql: Function): Promise<PostQL[]> => { |
| @@ -31,6 +31,6 @@ | |||
| }, | |||
| "jsRules": {}, | |||
| "linterOptions": { | |||
| "exclude": ["node_modules/**/*", "tools/**/*"] | |||
| "exclude": ["*/node_modules/**/*"] | |||
| } | |||
| } | |||
There was a problem hiding this comment.
add this:
"ban-types": [
true,
["Object", "Use {} instead."],
["String"],
["Function", "Use more precise type"]
]
to rules please
There was a problem hiding this comment.
even though it doesn't lint ./gatsby, just for the future
There was a problem hiding this comment.
I think that String object may be used in code 😄
magicmatatjahu
force-pushed
the
restructuring
branch
from
08dce61
to
a4e1ea7
Compare
gatsby/config/rss-feed.ts
Outdated
| excerpt: string; | ||
| html: string; | ||
| fields: { | ||
| slug: string; |
There was a problem hiding this comment.
slug: string?, at least from what you said to me
Description
Changes proposed in this pull request:
Related issue(s)
#287