Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic Sources for serverless #9425

Merged
merged 5 commits into from
Dec 20, 2023
Merged

Dynamic Sources for serverless #9425

merged 5 commits into from
Dec 20, 2023

Conversation

Cortey
Copy link
Contributor

@Cortey Cortey commented Nov 29, 2023 •
edited
Loading

Description
Add support for dynamic sources

Related issue(s)
kyma-project/serverless#417

@Cortey Cortey added area/ci Issues or PRs related to CI related topics kind/feature Categorizes issue or PR as related to a new feature. labels Nov 29, 2023
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2023
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 29, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2023 •
edited
Loading

Plan Result

CI link

Plan: 0 to add, 2 to change, 0 to destroy.
  • Update
    • module.artifact_registry["modules-internal"].google_artifact_registry_repository.artifact_registry
    • module.service_account_keys_cleaner.google_cloud_scheduler_job.service_account_keys_cleaner
Change Result (Click me) 
  # module.artifact_registry["modules-internal"].google_artifact_registry_repository.artifact_registry will be updated in-place
  ~ resource "google_artifact_registry_repository" "artifact_registry" {
        id               = "projects/kyma-project/locations/europe/repositories/modules-internal"
        name             = "modules-internal"
        # (11 unchanged attributes hidden)

      + docker_config {
          + immutable_tags = false
        }
    }

  # module.service_account_keys_cleaner.google_cloud_scheduler_job.service_account_keys_cleaner will be updated in-place
  ~ resource "google_cloud_scheduler_job" "service_account_keys_cleaner" {
        id               = "projects/sap-kyma-prow/locations/europe-west3/jobs/service-account-keys-cleaner"
        name             = "service-account-keys-cleaner"
        # (8 unchanged attributes hidden)

      ~ http_target {
          ~ uri         = "https://service-account-keys-cleaner-q25ja7ch3q-ez.a.run.app/?project=sap-kyma-prow&age=24" -> "https://service-account-keys-cleaner-q25ja7ch3q-ez.a.run.app?project=sap-kyma-prow&age=24"
            # (2 unchanged attributes hidden)

            # (1 unchanged block hidden)
        }
    }

Plan: 0 to add, 2 to change, 0 to destroy.

Changes to Outputs:
  ~ artifact_registry                                   = {
      ~ modules-internal = {
          ~ artifact_registry_collection = {
                id                        = "projects/kyma-project/locations/europe/repositories/modules-internal"
                name                      = "modules-internal"
              ~ update_time               = "2023-11-30T13:48:08.057980Z" -> "2023-11-30T14:34:08.086505Z"
                # (16 unchanged attributes hidden)
            }
        }
    }

@Cortey
Copy link
Contributor Author

Cortey commented Nov 29, 2023

/test all

1 similar comment
@Cortey
Copy link
Contributor Author

Cortey commented Nov 29, 2023

/test all

@Cortey Cortey force-pushed the change_target_used branch from f3ab14a to 6a5f71d Compare November 29, 2023 13:46
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 29, 2023
@Cortey
Copy link
Contributor Author

Cortey commented Nov 29, 2023

/test all

3 similar comments
@Cortey
Copy link
Contributor Author

Cortey commented Nov 29, 2023

/test all

@Cortey
Copy link
Contributor Author

Cortey commented Nov 30, 2023

/test all

@Cortey
Copy link
Contributor Author

Cortey commented Nov 30, 2023

/test all

@Cortey Cortey mentioned this pull request Dec 1, 2023
Closed
4 tasks
@Cortey Cortey force-pushed the change_target_used branch from 4d4f777 to 4b7dfcf Compare December 20, 2023 09:59
@Cortey Cortey changed the title [WIP] Dynamic Sources POC Dynamic Sources for serverless Dec 20, 2023
@Cortey Cortey marked this pull request as ready for review December 20, 2023 10:04
@Cortey Cortey requested review from neighbors-dev-bot and a team as code owners December 20, 2023 10:04
@Cortey Cortey requested a review from a team as a code owner December 20, 2023 10:04
@Cortey Cortey requested review from Sawthis and mm-mariani December 20, 2023 10:04
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 20, 2023
@kyma-bot
Copy link
Contributor

kyma-bot commented Dec 20, 2023 •
edited
Loading

@Cortey: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-test-infra-vpathguard 4d4f777 link true /test pull-test-infra-vpathguard
pull-build-githubrelease 4d4f777 link true /test pull-build-githubrelease

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Cortey
Copy link
Contributor Author

Cortey commented Dec 20, 2023

/retest

@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 20, 2023
m00g3n
m00g3n approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot merged commit 7ceef58 into kyma-project:main Dec 20, 2023
8 checks passed
@kyma-bot
Copy link
Contributor

@Cortey: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key serverless-integration-k3d.yaml using file prow/jobs/kyma-project/kyma/tests/serverless/serverless-integration-k3d.yaml
  • key serverless-verify.yaml using file prow/jobs/kyma-project/serverless/serverless-verify.yaml

In response to this:

Description
Add support for dynamic sources

Related issue(s)
kyma-project/serverless#417

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dekiel pushed a commit to dekiel/test-infra that referenced this pull request Jan 12, 2024
@Cortey @dekiel
Dynamic Sources for serverless (kyma-project#9425)
4151d7d 
* Merge to main

* add_missing_changes

* env

* remove_pjtester

* add_target
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sawthis Sawthis Sawthis approved these changes

@m00g3n m00g3n m00g3n approved these changes

@halamix2 halamix2 halamix2 approved these changes

@neighbors-dev-bot neighbors-dev-bot Awaiting requested review from neighbors-dev-bot neighbors-dev-bot is a code owner

@mm-mariani mm-mariani Awaiting requested review from mm-mariani mm-mariani is a code owner automatically assigned from kyma-project/prow

Assignees

@halamix2 halamix2

@m00g3n m00g3n

@Sawthis Sawthis

Labels
add-or-update area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Cortey @kyma-bot @halamix2 @m00g3n @Sawthis