Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update Fluent Bit Config ADR #624

Merged
merged 2 commits into from
Dec 11, 2023
Merged

docs: Update Fluent Bit Config ADR #624

merged 2 commits into from
Dec 11, 2023

Conversation

chrkl
Copy link
Contributor

@chrkl chrkl commented Dec 11, 2023

Description

Changes proposed in this pull request (what was done and why):

  • Update Fluent Bit config ADR to document reasons to keep the filesystem buffer

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • New features have a milestone set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub issue has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • Adjusted the documentation if the change is user-facing.
  • The feature is unit-tested
  • The feature is e2e-tested

@chrkl chrkl requested a review from a team as a code owner December 11, 2023 15:29
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 11, 2023
skhalash
skhalash previously approved these changes Dec 11, 2023
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 11, 2023
@chrkl @NHingerl
Update docs/contributor/arch/002-fluent-bit-without-file-system-buffe…
a3dee79 
…r.md

Co-authored-by: Nina Hingerl <76950046+NHingerl@users.noreply.github.com>
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Dec 11, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 11, 2023
@kyma-bot kyma-bot merged commit 47288aa into kyma-project:main Dec 11, 2023
5 checks passed
@chrkl chrkl deleted the update-buffer-adr branch December 11, 2023 15:49
@chrkl chrkl mentioned this pull request Dec 11, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NHingerl NHingerl NHingerl approved these changes

@skhalash skhalash skhalash left review comments

Assignees

@skhalash skhalash

@NHingerl NHingerl

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrkl @skhalash @NHingerl @kyma-bot