Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: False positive NoLogsDelivered LogPipeline status reason #1397

Merged
merged 15 commits into from
Aug 29, 2024
Merged

fix: False positive NoLogsDelivered LogPipeline status reason #1397

merged 15 commits into from
Aug 29, 2024

Conversation

skhalash
Copy link
Collaborator

@skhalash skhalash commented Aug 28, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • Before the NoLogsDelievered status reason was calculated based on 2 alerts: LogAgentReceiverReadLogs and LogAgentExporterSentLogs. This caused some flakiness when both alert statuses were not updated simultaneously. In this PR, a new alert was introduced that is logically the same, but boolean logic is done in PromQL instead of the Go code. Moreover, the for alert attribute was set to 1 minute to prevent flakiness.

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@skhalash skhalash added kind/bug Categorizes issue or PR as related to a bug. area/logs LogPipeline labels Aug 28, 2024
@skhalash skhalash added this to the 1.23.0 milestone Aug 28, 2024
@skhalash skhalash requested a review from a team as a code owner August 28, 2024 12:44
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 28, 2024
@skhalash
Revert leftover
93f507c
@skhalash
Merge branch 'self-monitor-apply-set-ops-in-promql-exprs' of github.c…
107eb79 
…om:skhalash/telemetry-manager into self-monitor-apply-set-ops-in-promql-exprs
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 28, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 28, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 29, 2024
@kyma-bot kyma-bot merged commit 5d3b12d into kyma-project:main Aug 29, 2024
47 checks passed
@TeodorSAP TeodorSAP mentioned this pull request Aug 30, 2024
Open
@skhalash skhalash deleted the self-monitor-apply-set-ops-in-promql-exprs branch September 3, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeodorSAP TeodorSAP TeodorSAP approved these changes

Assignees

@TeodorSAP TeodorSAP

Labels
area/logs LogPipeline cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@skhalash @TeodorSAP @kyma-bot