generated from kyma-project/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: False positive NoLogsDelivered LogPipeline status reason #1397
Merged
kyma-bot
merged 15 commits into
kyma-project:main
from
skhalash:self-monitor-apply-set-ops-in-promql-exprs
Aug 29, 2024
Merged
fix: False positive NoLogsDelivered LogPipeline status reason #1397
kyma-bot
merged 15 commits into
kyma-project:main
from
skhalash:self-monitor-apply-set-ops-in-promql-exprs
Aug 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skhalash
added
kind/bug
Categorizes issue or PR as related to a bug.
area/logs
LogPipeline
labels
Aug 28, 2024
kyma-bot
added
cla: yes
Indicates the PR's author has signed the CLA.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Aug 28, 2024
…om:skhalash/telemetry-manager into self-monitor-apply-set-ops-in-promql-exprs
kyma-bot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Aug 28, 2024
kyma-bot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Aug 28, 2024
… self-monitor-apply-set-ops-in-promql-exprs
…om:skhalash/telemetry-manager into self-monitor-apply-set-ops-in-promql-exprs
TeodorSAP
reviewed
Aug 29, 2024
TeodorSAP
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request (what was done and why):
NoLogsDelievered
status reason was calculated based on 2 alerts:LogAgentReceiverReadLogs
andLogAgentExporterSentLogs
. This caused some flakiness when both alert statuses were not updated simultaneously. In this PR, a new alert was introduced that is logically the same, but boolean logic is done in PromQL instead of the Go code. Moreover, thefor
alert attribute was set to 1 minute to prevent flakiness.Changes refer to particular issues, PRs or documents:
Traceability
Related Issues
section.