docs: Update local-test-setup.md to use scripts #2178

c-pius · 2025-01-15T08:00:06Z

Description

Changes proposed in this pull request:

Updates local-test-setup.md to make use of our testing scripts
❓ ask to reviewer
- please test it locally so we see if it works across machines
- for reviewing, view the file directly which should be easier than the diff: https://github.com/kyma-project/lifecycle-manager/blob/a5babc559a123a3b3ffce2250ad28b37727c5a2d/docs/contributor/04-local-test-setup.md

Related issue(s)

docs/contributor/04-local-test-setup.md

…ma-project#2197) * reference controller in architecture docs * fix markdown lint * improve docs

) * feat: Add metadata and status helpers to Kyma type * add go sum * cleanup go mod, add api to coverage * remove api from unit-test coverage * feat: MaintenanceWindow service * chore(dependabot): bump k8s.io/apimachinery from 0.32.0 to 0.32.1 in /api (kyma-project#2185) chore(dependabot): bump k8s.io/apimachinery in /api Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.32.0 to 0.32.1. - [Commits](kubernetes/apimachinery@v0.32.0...v0.32.1) --- updated-dependencies: - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(dependabot): bump sigs.k8s.io/controller-runtime from 0.19.4 to 0.20.0 (kyma-project#2192) chore(dependabot): bump sigs.k8s.io/controller-runtime Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.19.4 to 0.20.0. - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.19.4...v0.20.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/controller-runtime dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: Add metadata and status helpers to Kyma type * cleanup go mod, add api to coverage * remove obsolete comment * fix fake arguments in suite_test * avoid handler name in suite_test * rename to maintenanceWindow consistently * underscore unused receiver arg * omit receiver arg --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

docs/contributor/04-local-test-setup.md

Co-authored-by: Małgorzata Świeca <malgorzata.swieca@sap.com>

docs/contributor/04-local-test-setup.md

mmitoraj

Sorry for the confusion but I meant the whole code snippet (on the grey background) that belongs to an ordered list item to be indented. I sent you an example in Slack :)

docs/contributor/04-local-test-setup.md

Co-authored-by: Małgorzata Świeca <malgorzata.swieca@sap.com>

c-pius requested review from a team as code owners January 15, 2025 08:00

kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 15, 2025

docs: Update local-test-setup.md to use scripts

ab674e8

c-pius force-pushed the docs/loca-test-setup-using-scripts branch from a5babc5 to ab674e8 Compare January 15, 2025 08:01

nesmabadr self-assigned this Jan 16, 2025

nesmabadr reviewed Jan 16, 2025

View reviewed changes

docs/contributor/04-local-test-setup.md Outdated Show resolved Hide resolved

docs/contributor/04-local-test-setup.md Show resolved Hide resolved

c-pius commented Jan 16, 2025

View reviewed changes

docs/contributor/04-local-test-setup.md Outdated Show resolved Hide resolved

Update docs/contributor/04-local-test-setup.md

dfaf36a

nesmabadr previously approved these changes Jan 16, 2025

View reviewed changes

kyma-bot added the lgtm Looks good to me! label Jan 16, 2025

lindnerby requested a review from mmitoraj January 17, 2025 08:32

c-pius assigned mmitoraj and unassigned nesmabadr Jan 17, 2025

Merge branch 'main' into docs/loca-test-setup-using-scripts

9fd559b

c-pius dismissed nesmabadr’s stale review via 9fd559b January 20, 2025 14:21

kyma-bot removed the lgtm Looks good to me! label Jan 20, 2025

amritanshusikdar and others added 3 commits January 21, 2025 08:05

docs: Reference Mandatory Modules Controller in Architecture Docs (ky…

dcf2572

…ma-project#2197) * reference controller in architecture docs * fix markdown lint * improve docs

title numbering and casing

c525f4e

kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 21, 2025

Merge branch 'main' into docs/loca-test-setup-using-scripts

641c91a

kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 21, 2025

Merge branch 'main' into docs/loca-test-setup-using-scripts

8eef125

mmitoraj reviewed Jan 22, 2025

View reviewed changes

Apply suggestions from code review

d1a8ac1

Co-authored-by: Małgorzata Świeca <malgorzata.swieca@sap.com>

c-pius commented Jan 22, 2025

View reviewed changes

docs/contributor/04-local-test-setup.md Outdated Show resolved Hide resolved

docs/contributor/04-local-test-setup.md Outdated Show resolved Hide resolved

docs/contributor/04-local-test-setup.md Outdated Show resolved Hide resolved

c-pius added 3 commits January 22, 2025 13:24

Update docs/contributor/04-local-test-setup.md

c3c6205

indent scripts

781ab2d

link CRDs

45882bd

c-pius requested a review from mmitoraj January 22, 2025 12:28

mmitoraj reviewed Jan 22, 2025

View reviewed changes

docs/contributor/04-local-test-setup.md Outdated Show resolved Hide resolved

docs/contributor/04-local-test-setup.md Outdated Show resolved Hide resolved

c-pius and others added 5 commits January 22, 2025 13:48

Update docs/contributor/04-local-test-setup.md

b0980c3

Co-authored-by: Małgorzata Świeca <malgorzata.swieca@sap.com>

Update docs/contributor/04-local-test-setup.md

075a967

Co-authored-by: Małgorzata Świeca <malgorzata.swieca@sap.com>

fix indentation

60d3254

fix indentation and numbering

05e0ca7

Merge branch 'main' into docs/loca-test-setup-using-scripts

5709622

mmitoraj approved these changes Jan 22, 2025

View reviewed changes

kyma-bot added the lgtm Looks good to me! label Jan 22, 2025

nesmabadr approved these changes Jan 22, 2025

View reviewed changes

kyma-bot assigned nesmabadr Jan 22, 2025

c-pius enabled auto-merge (squash) January 22, 2025 14:25

c-pius merged commit 1fd218e into kyma-project:main Jan 22, 2025
68 of 69 checks passed

c-pius deleted the docs/loca-test-setup-using-scripts branch January 22, 2025 14:28

c-pius assigned c-pius and unassigned nesmabadr and mmitoraj Jan 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: Update local-test-setup.md to use scripts #2178

docs: Update local-test-setup.md to use scripts #2178

c-pius commented Jan 15, 2025 •

edited

Loading

mmitoraj left a comment •

edited

Loading

docs: Update local-test-setup.md to use scripts #2178

docs: Update local-test-setup.md to use scripts #2178

Conversation

c-pius commented Jan 15, 2025 • edited Loading

mmitoraj left a comment • edited Loading

Choose a reason for hiding this comment

c-pius commented Jan 15, 2025 •

edited

Loading

mmitoraj left a comment •

edited

Loading